Skip to content

docs(spec): document REQUEST_ID_MISSING error code (401) - #508

Merged
jklein24 merged 1 commit into
mainfrom
spec-request-id-missing
May 28, 2026
Merged

docs(spec): document REQUEST_ID_MISSING error code (401)#508
jklein24 merged 1 commit into
mainfrom
spec-request-id-missing

Conversation

@jklein24

@jklein24 jklein24 commented May 27, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

Follow-up to grid-api #500 (merged). webdev PR #27767 (AT-5342) added a new `REQUEST_ID_MISSING` ErrorCode (401) on the server so that signed-retry endpoints can distinguish two failure modes that were previously lumped under `WALLET_SIGNATURE_MISSING`:

  • WALLET_SIGNATURE_MISSING — caller sent `Request-Id` but forgot `Grid-Wallet-Signature`
  • REQUEST_ID_MISSING — caller sent `Grid-Wallet-Signature` but forgot `Request-Id`

Kevin's review on the server PR pointed out that lumping these under one code defeats the point of having specific subcodes. The server change is in; this PR brings the spec into sync so the SDKs can learn the new code.

Files

  • `openapi/components/schemas/errors/Error401.yaml` — add `REQUEST_ID_MISSING` to the enum + description table
  • `openapi.yaml`, `mintlify/openapi.yaml` — re-bundled

Test plan

  • `make build` clean
  • `npx @redocly/cli lint openapi.yaml` clean (no errors; 33 pre-existing warnings)
  • Bundle contains `REQUEST_ID_MISSING`

Refs AT-5342 under epic AT-5324

@jklein24
docs(spec): document REQUEST_ID_MISSING error code (401)
c6a62d9 
Follow-up to PR #500. webdev PR #27767 added a new REQUEST_ID_MISSING
ErrorCode (401) so that signed-retry endpoints can distinguish 'I
forgot the Grid-Wallet-Signature header' from 'I forgot the Request-Id
header'. SDK clients need this in the Error401 enum to surface the
distinction.

Refs AT-5342
@vercel

vercel Bot commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment May 27, 2026 12:28am

Request Review

@github-actions

github-actions Bot commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

docs(spec): document REQUEST_ID_MISSING error code (401)

csharp

docs(spec): document REQUEST_ID_MISSING error code (401)

go

docs(spec): document REQUEST_ID_MISSING error code (401)

kotlin

docs(spec): document REQUEST_ID_MISSING error code (401)

openapi

docs(spec): document REQUEST_ID_MISSING error code (401)

php

docs(spec): document REQUEST_ID_MISSING error code (401)

python

docs(spec): document REQUEST_ID_MISSING error code (401)

ruby

docs(spec): document REQUEST_ID_MISSING error code (401)

typescript

docs(spec): document REQUEST_ID_MISSING error code (401)
⚠️ grid-openapi studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗

⚠️ grid-ruby studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗ → build ⏭️ → lint ✅ → test ✅

⚠️ grid-typescript studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗ → build ⏭️ → lint ⏭️ → test ✅

⚠️ grid-python studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗ → build ⏭️ → lint ⏭️ → test ✅

⚠️ grid-csharp studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ❗ → build ⏭️ → lint ⏭️ → test ❗

⚠️ grid-go studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ❗ → build ⏭️ → lint ❗ → test ❗

go get github.com/stainless-sdks/grid-go@86e8b40f54b8210b0efab44e0c944b6542507f25
⚠️ grid-php studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗ → lint ✅ → test ✅

⚠️ grid-kotlin studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ❗ → build ⏭️ → lint ⏭️ → test ❗

⚠️ grid-cli studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ❗ → build ⏭️ → lint ⏭️ → test ❗

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-05-28 17:48:24 UTC

@jklein24
jklein24 marked this pull request as ready for review May 27, 2026 00:39
@jklein24
jklein24 requested a review from kphurley7 May 27, 2026 00:39
@jklein24
jklein24 enabled auto-merge (squash) May 27, 2026 00:39
@greptile-apps

greptile-apps Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds the REQUEST_ID_MISSING (401) error code to the OpenAPI spec, splitting a previously ambiguous failure mode away from WALLET_SIGNATURE_MISSING so that signed-retry callers can distinguish which required header is absent.

  • openapi/components/schemas/errors/Error401.yaml — source file gains the new enum value and a description table row explaining that Request-Id is required when Grid-Wallet-Signature is present.
  • openapi.yaml and mintlify/openapi.yaml — both generated bundles are re-built and reflect the same change identically, with no drift between them.

Confidence Score: 5/5

Safe to merge — the change is purely additive documentation, adding a new enum value and description row to the 401 error schema with consistent updates across the source and both generated bundles.

The edit touches only the error code description table and enum in three files (one source, two generated bundles). Both bundles match the source exactly, no pre-existing enum values are modified, and the new description accurately reflects the complementary failure mode described in the PR.

No files require special attention.

Important Files Changed
Filename Overview
openapi/components/schemas/errors/Error401.yaml Adds REQUEST_ID_MISSING to the error code description table and enum; source of truth for the bundled files.
openapi.yaml Generated bundle re-built from openapi/; mirrors the Error401.yaml change consistently.
mintlify/openapi.yaml Mintlify copy of the generated bundle; change is identical to openapi.yaml, no drift.

Flowchart

 
%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Signed-retry request received] --> B{Request-Id header present?}
    B -- No --> C[401 REQUEST_ID_MISSING\nGrid-Wallet-Signature present\nbut Request-Id missing]
    B -- Yes --> D{Grid-Wallet-Signature header present?}
    D -- No --> E[401 WALLET_SIGNATURE_MISSING\nRequest-Id present\nbut Grid-Wallet-Signature missing]
    D -- Yes --> F{Signature valid?}
    F -- Malformed --> G[401 WALLET_SIGNATURE_MALFORMED]
    F -- Body mismatch --> H[401 WALLET_SIGNATURE_BODY_MISMATCH]
    F -- Invalid --> I[401 WALLET_SIGNATURE_INVALID]
    F -- Valid --> J[Request proceeds]
Loading

Reviews (1): Last reviewed commit: "docs(spec): document REQUEST_ID_MISSING ..." | Re-trigger Greptile

@jklein24
jklein24 requested a review from DhruvPareek May 28, 2026 06:01
@jklein24
jklein24 merged commit afcca90 into main May 28, 2026
8 checks passed
@jklein24
jklein24 deleted the spec-request-id-missing branch May 28, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DhruvPareek DhruvPareek DhruvPareek approved these changes
@kphurley7 kphurley7 Awaiting requested review from kphurley7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jklein24 @DhruvPareek